ci: Pinning the server build runs to Ubuntu 22.04 because of Flapdoodle errors#38723
ci: Pinning the server build runs to Ubuntu 22.04 because of Flapdoodle errors#38723mohanarpit merged 1 commit intoreleasefrom
Conversation
WalkthroughThe pull request focuses on updating the GitHub Actions workflow configurations for Appsmith Server's build and integration tests. The primary changes involve transitioning from Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
github-actions
bot
added
skip-changelog
| echo "Tests failed, exiting with status 1." | ||
| exit 1 | ||
| fi | ||
| if [[ "${{ inputs.is-pg-build }}" == "true" ]]; then |
There was a problem hiding this comment.
There's no change here. It's just formatting changes to make it compatible with YML formatting in our code base. Please ignore this.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
.github/workflows/server-build.yml (1)
290-290: Remove trailing whitespace.There is trailing whitespace at the end of this line.
- echo "$content" >> "$GITHUB_STEP_SUMMARY" + echo "$content" >> "$GITHUB_STEP_SUMMARY"🧰 Tools
🪛 yamllint (1.35.1)
[error] 290-290: trailing spaces
(trailing-spaces)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/workflows/server-build.yml(3 hunks).github/workflows/server-integration-tests.yml(3 hunks)
🧰 Additional context used
🪛 actionlint (1.7.4)
.github/workflows/server-integration-tests.yml
20-20: label "ubuntu-22.04-8core" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
.github/workflows/server-build.yml
54-54: label "ubuntu-22.04-8core" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
🪛 yamllint (1.35.1)
.github/workflows/server-build.yml
[error] 290-290: trailing spaces
(trailing-spaces)
🔇 Additional comments (3)
.github/workflows/server-integration-tests.yml (1)
96-106: LGTM! Clean test execution setup.The changes maintain the same functionality while improving code readability through better formatting.
.github/workflows/server-build.yml (2)
206-303: Well-structured test execution and reporting logic.The changes improve the workflow with:
- Clear separation of database setup
- Better handling of test failures and retries
- Improved test result processing and reporting
🧰 Tools
🪛 yamllint (1.35.1)
[error] 290-290: trailing spaces
(trailing-spaces)
Line range hint
20-20: Verify the impact of pinning to Ubuntu 22.04.While pinning to Ubuntu 22.04 addresses the Flapdoodle errors, we should:
- Fix the invalid runner labels in both workflow files
- Document this as a temporary solution
- Create a follow-up ticket for upgrading Flapdoodle
Also applies to: 54-54
✅ Verification successful
The Ubuntu 22.04 pin is safe, but runner labels need attention
The Ubuntu 22.04 pin in server-build.yml is an isolated change that won't impact other workflows. However, the invalid runner labels still need to be fixed as mentioned in the original review.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Check if there are any other workflow files using ubuntu-latest rg -l "ubuntu-latest" .github/workflows/Length of output: 1556
Script:
#!/bin/bash # Check for Flapdoodle usage in workflow files rg -l "flapdoodle" .github/workflows/ # Check for server test patterns in workflow files rg -l "server.*test|test.*server" .github/workflows/Length of output: 443
🧰 Tools
🪛 actionlint (1.7.4)
54-54: label "ubuntu-22.04-8core" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
2 participants
Description
Flapdoodle, our Mongo embedded testing library throws errors when running Junit tests on Ubuntu 24.04. This is because of a mismatch of openssl version from Ubuntu 22.04 to Ubuntu 24.04. Hence pinning our CI for server builds to Ubuntu 22.04 for now. Will issue a holistic fix with Flapdoodle upgrade later.
Automation
/ok-to-test tags=""
🔍 Cypress test results
Caution
If you modify the content in this section, you are likely to disrupt the CI result for your PR.
Communication
Should the DevRel and Marketing teams inform users about this change?
Summary by CodeRabbit
ubuntu-latest-8-corestoubuntu-22.04-8core